Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove call_tip function and test case for that #10104

Merged
merged 1 commit into from Dec 25, 2016
Merged

remove call_tip function and test case for that #10104

merged 1 commit into from Dec 25, 2016
+5 −82

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Dec 23, 2016 •
edited

@srinivasreddy srinivasreddy mentioned this pull request Dec 23, 2016
Closed
@Carreau
Copy link
Member

Carreau commented Dec 23, 2016

Thanks ! Though there seem to be some use of check_calltip that would need to be removed as well. And I think we want to go through a Deprecation period (ie undocument with @undoc and raise DeprecationWarnings) before removing.

@srinivasreddy
This commit,
33ccc29 
* Add deprecation and warning message for call_tip function

* Remove check_calltip function in tests

* Remove all the tests which use check_calltip to  test 'call_tip' functionality.
@srinivasreddy
Copy link
Contributor Author

@Carreau pls let me know what do you think!.

@Carreau
Copy link
Member

Carreau commented Dec 25, 2016

Hi @srinivasreddy,

Sorry I mis-expressed myself !

The @undoc and DEPRECATED docstring are great !

I would not have removed the all docstring, and left the test for the later actual removal.
Also the next version of IPython will likely be 6.0 and not 5.2 but you had no way of doing that.

So I'll merge and we can fix things if necessary later !

Thanks ! you contribution are highly appreciated.

@Carreau Carreau merged commit 71426e6 into ipython:master Dec 25, 2016
@Carreau Carreau modified the milestone: 6.0 Dec 25, 2016
@srinivasreddy srinivasreddy deleted the 9102 branch January 18, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srinivasreddy @Carreau